fix: configure histogram buckets for P99 latency dashboard#18
Merged
Conversation
The Prometheus exporter defaults to emitting summaries (quantile-based) instead of true histograms with _bucket metrics. The Grafana dashboard uses histogram_quantile() which requires _bucket/le labels, resulting in "No data" for the P99 Latency panel. Add explicit bucket boundaries to PrometheusBuilder so histograms are exported with _bucket, _sum, and _count suffixes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_bucketlabelshistogram_quantile()which requires_bucket/lemetrics, causing "No data"1msto10s) toPrometheusBuilderso histograms export correctlyTest plan
cargo buildpassesrpc_request_duration_seconds_bucketappears in/metricsoutput🤖 Generated with Claude Code